PD Type Translations #1404
PD Type Translations #1404
Conversation
- Included strings and translations from the recombinant table yaml files.
|
If you want to get fancy and reduce some duplication you could extract these strings from the yaml files with a custom babel message extractor |
- Moved sql error messages to schema yaml files. - Added shortname for the PD types that need it.
- Added pd shortnames to use instead of string concatenation.
- Added custom message extractor to get strings from the Recombinant schemas and into the translation interfece. - Removed PD strings from `string.py`.
- Added missed trigger string for ati.
- Minor syntax fixes.
- Added line numbers for custom message extractor for pd yamls.
- Updated catalogs with new message extractions.
|
depends on open-data/ckanext-recombinant#116 |
|
@wardi custom message extractor is done now. |
- Added custom safe loader class to record line numbers for string tags.
- Made code gooder.
- Simple loop of recombinant recortds in PD message extractor.
- Config file for CircleCI.
- Updated readme with new translation stuffs. - Added circleci badge. - Added Slack notifications.
|
Trying to get our test moved to circleci. (https://github.com/open-data/ckanext-canada/tree/circleci) Ran into a roadblock and had to open up a support ticket with circleci. But hopefully that can get solved and we can figure out why these string triggers are failing. |
- Removed circleci changes as that is now in a different branch. - Added back normal tests.
- Temp debugging.
- Readme update. - Reverted debugging.
- Debugging for some of the pd contracts tests.
- YAML pip strings not supported for trigger strings.
- Removed debug logging from contracts tests. - Added comments to pd schema yamls.
|
@wardi okay cool, so with that fix to Recombinant and some minor fixes in the pd tests and yaml files here the tests are all working now, yay! Are you able to take a final look at this to confirm it is all good to go? |
|
@wardi haha no, they are just for some inline comments for us :D |
feat(i18n): translations for PD table yaml files;