feat: Create DRF for course settings and course details views out of current Django views #32397 #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaustavb12
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
👍
@pkulkark The replaced API is working correctly.
Please consider this approved once the review comment is addressed
- I tested this: Tested new APIs in devstack
- I read through the code
- I checked for accessibility issues
- Includes documentation
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository.
This reverts commit 8940cb3 since it will be replaced with a new commit from upstream.
current Django views (openedx#32397) (cherry picked from commit ed1e5f5) Co-authored-by: ruzniaievdm <[email protected]>
pkulkark
force-pushed
the
pooja/backport-details-settings-api
branch
2 times, most recently
from
3c68613
to
0f846c2
Compare
pkulkark
force-pushed
the
pooja/backport-details-settings-api
branch
from
0f846c2
to
2a5b540
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the previously merged details_settings API changes (from #533) and backports the upstream PR openedx#32397.
(cherry picked from commit ed1e5f5)
Supporting Information
OpenCraft Internal Jira ticket: BB-7664
Testing Instructions
TBD