-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review the new codes from extensions #1707
Comments
Reviewed all extensions maintained by OCDS. Since the last review was completed (#1157) the following extensions have added codes to core codelists:
codes marked with a * have already been added to 1.2 The new EU specific codes from Organization classification have already been added to From Legal basis the other 2 codes this extension adds to I think all of the |
Re: legal basis: once open-contracting-extensions/ocds_legalBasis_extension#11 is merged, legal basis will no longer use that subschema, so we actually want to remove the codes from itemClassificationScheme.
partyRole (EU / Document publisher / Budget breakdown / Subcontracting) requires more discussion. Codes are added in one of two cases. (1) There is a corresponding organization reference. (2) Simply describing a party as having the role serves a use case. The first case covers:
The second case is why we have (in the case of parties that might already exist):
And why we have (in the case of parties that might not have any organization references):
Now if we consider each of the extension codes (not already in 1.2):
When adding new party role codes, add them near similar codes, e.g. order submissionReceiptBody, evaluationBody, then reviewBody and mediationBody, as that matches the timeline of a contracting process. leadBuyer and leadTenderer can follow buyer and tenderer, respectively. |
I agree that it should just stay in the extension.
Good point! I agree with your conclusions Re. partyRole codes. For procurementServiceProvider your comment in #1180 (comment)
I think still stands, we could attempt to find a definition that would work for OCDS but unless we find evidence that it would be useful outside of the EU then I don't think it's worth it |
OK to leave out procurementServiceProvider - thanks for finding that comment :) |
EU
Codes were last added in #1225
See extension changelog https://extensions.open-contracting.org/en/extensions/eu/1.1/#changelog
For now, when merging the 1.1 branch of the extension into its 1.2 branch, I omitted these codelist additions and corresponding readme changes.
New extensions
Non-exhaustive
The text was updated successfully, but these errors were encountered: