Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EU: remove codelist codes that have been added to OCDS 1.2 #236

Open
odscjen opened this issue Dec 13, 2024 · 3 comments · May be fixed by open-contracting-extensions/ocds_eu_extension#20

Comments

@odscjen
Copy link

odscjen commented Dec 13, 2024

OCDS 1.2 has added the following codes from the EU extension to:

  • documentType.csv
    • legislation
  • partyRole.csv
    • leadBuyer
    • leadTenderer
    • submissionReceiptBody
    • evaluationBody

See open-contracting/standard#1707 for discussion about which codes were added to the core standard

@jpmckinney
Copy link
Member

Sounds good. We can make this change already, since the 1.2 version of the extension isn't advertised.

@odscjen
Copy link
Author

odscjen commented Dec 16, 2024

The 1.2 branch has had both of these codelists removed (see open-contracting-extensions/ocds_eu_extension@c3ed45b). +itemClassificationScheme.csv has also been removed although it's removal isn't mentioned in the changelog and I can't seem to locate the exact commit it happened in open-contracting-extensions/ocds_eu_extension@1.1...1.2 but it shows up in the branch comparison.

The discussion in #1707 concluded that some of the codes in classificationScheme and partyRole should remain in the extension as they are EU specific, so this issue is actually about adding these codes into the 1.2 branch of the extension rather than removing codes.

The codelists with codes to add are:

  • +classificationScheme.csv
    • eu-vehicle-category
    • eu-cvd-contract-type
  • +partyRole.csv
    • procurementServiceProvider
    • eSender

It also looks like +relatedProcessScheme.csv has been removed from the 1.2 extension branch but there is also a code there that hasn't been added to 1.2 core so it also needs added back in:

  • eu-oj

@jpmckinney
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants