🌱 OCM Kueue Admission Check Controller #601
Conversation
z1ens
force-pushed
the
kueue-admission-check
branch
from
9cd1e93
to
8906715
Compare
| kubectl create -f env/multicluster.x-k8s.io_clusterprofiles.yaml | ||
|
|
||
| echo "Install managed-serviceaccount" | ||
| cd /path/to/managed-serviceaccount # TODO: Replace here with your actual path. |
There was a problem hiding this comment.
Replace with git clone [email protected]:open-cluster-management-io/managed-serviceaccount.git
| kubectl apply -f env/mg-sa-cma-0.6.0.yaml || true | ||
|
|
||
| echo "Install cluster-permission" | ||
| cd /path/to/OCM/cluster-permission # TODO: Replace here with your actual path. |
There was a problem hiding this comment.
Replace with git clone [email protected]:open-cluster-management-io/cluster-permission.git
|
|
||
| echo "Install resource-usage-collect-addon" | ||
| cd /path/to/addon-contrib/resource-usage-collect-addon # TODO: Replace here with your actual path. | ||
| IMAGE_NAME=zheshen/resource-usage-collect-addon:latest make deploy |
There was a problem hiding this comment.
It seems the image name is hardcoded in addontemplate https://github.com/open-cluster-management-io/addon-contrib/blob/main/resource-usage-collect-addon/deploy/resources/addon-template.yaml#L53 , need to replace it with example-addon-image.
There was a problem hiding this comment.
Yes a new PR has been created to fix the image problem.
open-cluster-management-io/addon-contrib#21
| apiVersion: cluster.open-cluster-management.io/v1beta1 | ||
| kind: Placement | ||
| metadata: | ||
| name: placement-sample2 |
There was a problem hiding this comment.
The name is inconsistent with placement-demo2-2.yaml resource name.
| weight: 1 | ||
| ``` | ||
| - You can manually edit the GPU resources on the managed clusters for testing. | ||
| ```bash |
There was a problem hiding this comment.
Add some details on what user should add to their node.
| parameters: | ||
| apiGroup: cluster.open-cluster-management.io | ||
| kind: Placement | ||
| name: placement-sample1 # An example placement to select clusters labeled with "nvidia-tesla-t4" GPU accelerator. |
There was a problem hiding this comment.
This is the placement name, should be placement-demo2.
| @@ -0,0 +1,66 @@ | |||
| apiVersion: multicluster.x-k8s.io/v1alpha1 | |||
| kind: AuthTokenRequest | |||
There was a problem hiding this comment.
I would not think we should have this, since this is not decided yet.
There was a problem hiding this comment.
yes, let's replace it with clusterpermission and managedserviceaccount.
z1ens
force-pushed
the
kueue-admission-check
branch
2 times, most recently
from
fd2a5b3
to
6a37b63
Compare
z1ens
changed the title
Signed-off-by: Zhe Shen <[email protected]>
z1ens
force-pushed
the
kueue-admission-check
branch
from
cd44a81
to
52b8963
Compare
| "resources": ["authtokenrequests/status"], | ||
| "verbs": ["update", "patch"] | ||
| } | ||
| }, |
There was a problem hiding this comment.
Remove the permission of authtokenrequests and authtokenrequests/status.
| ```bash | ||
| kubectl create -f ./job-demo1.yaml | ||
| ``` | ||
| - Check the workload on the managed clusters. |
There was a problem hiding this comment.
Adding the expected output for the "Check" would be nice.
Signed-off-by: Zhe Shen <[email protected]>
z1ens
force-pushed
the
kueue-admission-check
branch
from
f46cd9e
to
cf1612a
Compare
|
/lgtm |
|
@qiujian16 could you help take a final review? |
|
I think we should add some TODO and then we can merge
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, z1ens The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Zhe Shen <[email protected]>
|
/lgtm |
|
/lgtm |
|
/unhold |
openshift-merge-bot
bot
merged commit 3e3d4ea
into
open-cluster-management-io:main
Update 25.08
REF: #369