Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deployment securityContext #171

Merged

Conversation

zhiweiyin318
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (8474972) 23.39% compared to head (2ce1fc3) 23.22%.

Files Patch % Lines
pkg/proxyserver/controllers/manifests.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
- Coverage   23.39%   23.22%   -0.18%     
==========================================
  Files           9        9              
  Lines        1171     1180       +9     
==========================================
  Hits          274      274              
- Misses        881      890       +9     
  Partials       16       16              
Flag Coverage Δ
unit 23.22% <0.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhiweiyin318 zhiweiyin318 force-pushed the update-scc branch 2 times, most recently from 3a4b944 to 88efefc Compare December 7, 2023 14:50
@@ -220,3 +229,13 @@ func newProxyServerRoleBinding(config *proxyv1alpha1.ManagedProxyConfiguration)
}

}

func truePtr() *bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use pointer library?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@xuezhaojun
Copy link
Member

/lgtm

@xuezhaojun
Copy link
Member

/approve

Copy link

openshift-ci bot commented Dec 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xuezhaojun, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 8, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 00d2026 into open-cluster-management-io:main Dec 8, 2023
9 checks passed
@zhiweiyin318 zhiweiyin318 deleted the update-scc branch December 8, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants