Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docsum according to docker compose changes #590

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

yongfengdu
Copy link
Collaborator

@yongfengdu yongfengdu commented Nov 20, 2024

Added multimedia2text and video2audio service

Description

The summary of the proposed changes as long as the relevant motivation and context.

Issues

Fixes #579

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Copy link
Collaborator

@lianhao lianhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the yaml lint issue, others seems fine to me

@lianhao lianhao added this to the v1.1 milestone Nov 20, 2024
@lianhao lianhao added the V1.1 OPEA 1.1 RELEASE TAG label Nov 20, 2024
Copy link
Collaborator

@ashahba ashahba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great with the exception of one minor linter issue

helm-charts/docsum/values.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@ashahba ashahba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yongfengdu yongfengdu merged commit 05f426b into opea-project:main Nov 20, 2024
27 checks passed
Added multimedia2text and video2audio service

Signed-off-by: Dolpher Du <[email protected]>
chensuyue pushed a commit that referenced this pull request Nov 21, 2024
Added multimedia2text and video2audio service

Signed-off-by: Dolpher Du <[email protected]>
(cherry picked from commit 05f426b)
@yongfengdu yongfengdu deleted the docsum branch November 21, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V1.1 OPEA 1.1 RELEASE TAG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ci-auto] adapt the docsum helmchart for new pipeline component
3 participants