Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default kubernetes imagePullPolicy #587

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yongfengdu
Copy link
Collaborator

@yongfengdu yongfengdu commented Nov 19, 2024

For latest tag, it should use Always.
For tags other than latest, it will use IfNotPresent.
https://kubernetes.io/docs/concepts/containers/images/#imagepullpolicy-defaulting

Description

The summary of the proposed changes as long as the relevant motivation and context.

Issues

#597

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

@yongfengdu yongfengdu added this to the v1.2 milestone Nov 19, 2024
@yongfengdu
Copy link
Collaborator Author

Target for 1.2-dev.
We won't fix this for 1.1 release because IfNotPresent is proper policy for released version.

@eero-t
Copy link
Contributor

eero-t commented Nov 21, 2024

Target for 1.2-dev. We won't fix this for 1.1 release because IfNotPresent is proper policy for released version.

That is the default when policy is not specified, and tag is something else than "latest".

For latest tag, it should use Always.
For tags other than latest, it will use IfNotPresent.

Signed-off-by: Dolpher Du <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants