Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename image name XXX-hpu to XXX-gaudi #575

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Rename image name XXX-hpu to XXX-gaudi #575

merged 2 commits into from
Nov 19, 2024

Conversation

ZePan110
Copy link
Collaborator

Description

Rename image name XXX-hpu to XXX-gaudi.

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Copy link
Collaborator

@yongfengdu yongfengdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The test failure is due to lacking of new image named vllm-gaudi. Let's wait till the image is OK and CI passed.

@chensuyue chensuyue merged commit ae17665 into main Nov 19, 2024
20 checks passed
@chensuyue chensuyue deleted the rename-images branch November 19, 2024 14:45
@lianhao lianhao added this to the v1.1 milestone Nov 20, 2024
chensuyue pushed a commit that referenced this pull request Nov 21, 2024
Signed-off-by: ZePan110 <[email protected]>
(cherry picked from commit ae17665)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants