Update GMC manifest changes and misc fixes #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lianhao
requested review from
KfreeZ,
yongfengdu,
daisy-ycguo and
mkbhanda
as code owners
lianhao
requested review from
Ruoyu-y
and removed request for
daisy-ycguo and
KfreeZ
mkbhanda
approved these changes
Nov 15, 2024
microservices-connector/config/manifests/llm-uservice_vllm.yaml
Outdated
Show resolved
Hide resolved
| @@ -23,6 +23,9 @@ data: | |||
| HABANA_LOGS: "/tmp/habana_logs" | |||
There was a problem hiding this comment.
is this a gaudi service? what is nv in tgi_nv.yaml?
There was a problem hiding this comment.
good catch. We'll clean up later. Let's get this PR in first to unblock the error of running update_manifest.sh
There was a problem hiding this comment.
PR #567 should fix this
- Run as the default user of vllm upstream image since the upstream doesn't support run as non-default user - Adpat llm-uservice's vllm-values.yaml to ci-vllm-gaudi-values.yaml to enable CI on gaudi instead of xeon because of test speed Signed-off-by: Lianhao Lu <[email protected]>
Signed-off-by: Lianhao Lu <[email protected]>
lianhao
force-pushed
the
update_manifest
branch
from
298b24a
to
775fda6
Compare
lianhao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.