Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm/manifest: Sync HPA related K8S probe settings #459

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

lianhao
Copy link
Collaborator

@lianhao lianhao commented Sep 26, 2024

Description

Sync the mismatch between helm chart and GMC manifests introduced by PR #386

Issues

n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Sync the mismatch between helm chart and GMC manifests introduced by PR opea-project#386

Signed-off-by: Lianhao Lu <[email protected]>
Copy link
Contributor

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

(As disussed in #431, I'd rather see these values in their own files though, instead of being duplicated in top level charts.)

@daisy-ycguo daisy-ycguo merged commit c399578 into opea-project:main Oct 11, 2024
28 checks passed
@lianhao lianhao deleted the hpa_values branch October 11, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants