Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GMC crashes in e2e #395

Merged
merged 3 commits into from
Sep 4, 2024
Merged

fix GMC crashes in e2e #395

merged 3 commits into from
Sep 4, 2024

Conversation

KfreeZ
Copy link
Collaborator

@KfreeZ KfreeZ commented Sep 4, 2024

Description

fix for #394

Root cause analysis:

this issue is introduced by #383 , in this PR, I moved the deployment filters, but missed the

		CreateFunc: func(e event.CreateEvent) bool {
			return false
		}, DeleteFunc: func(e event.DeleteEvent) bool {
			return false
		},

without these two, the creation/deletion of the deployment triggers the reconcile,

the sequence to hit this issue is like: delete GMC pipeline -> trigger deployment deletion ->trigger graph status update, but graph is already deleted ->panic.

solution:

  • restore the create/delete filters
  • add protection code

Issues

#394

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

n/a

Tests

CI/CD cover the tests

@KfreeZ KfreeZ marked this pull request as ready for review September 4, 2024 17:53
@KfreeZ KfreeZ changed the title GMC crashes in e2e fix GMC crashes in e2e Sep 4, 2024
Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you for the detailed root cause analysis @KfreeZ

@mkbhanda mkbhanda merged commit 5a2b306 into opea-project:main Sep 4, 2024
7 of 12 checks passed
Yugar-1 pushed a commit to Yugar-1/GenAIInfra that referenced this pull request Sep 5, 2024
* add debug message

Signed-off-by: KfreeZ <[email protected]>

* ignore create/delete func

Signed-off-by: KfreeZ <[email protected]>

* add protection

Signed-off-by: KfreeZ <[email protected]>

---------

Signed-off-by: KfreeZ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants