Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix for #394
Root cause analysis:
this issue is introduced by #383 , in this PR, I moved the deployment filters, but missed the
without these two, the creation/deletion of the deployment triggers the reconcile,
the sequence to hit this issue is like: delete GMC pipeline -> trigger deployment deletion ->trigger graph status update, but graph is already deleted ->panic.
solution:
Issues
#394
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
n/a
Tests
CI/CD cover the tests