Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove useless yamls #346

Closed
wants to merge 2 commits into from
Closed

Conversation

KfreeZ
Copy link
Collaborator

@KfreeZ KfreeZ commented Aug 23, 2024

Description

    deleted:    config/manager/kustomization.yaml
    deleted:    config/manager/manager.yaml

these two files are used to generate a yaml file of deployment/service, it not needed in current project.

Issues

n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

n/a.

Tests

will be covered by CI/CD

Signed-off-by: KfreeZ <[email protected]>
Copy link
Collaborator

@lianhao lianhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems Makefile is referencing these files, need to change that accordingly

@lianhao
Copy link
Collaborator

lianhao commented Aug 23, 2024

The image registry within the CI is being rebuilt, please hold the test until it's done

@KfreeZ KfreeZ mentioned this pull request Aug 26, 2024
3 tasks
@KfreeZ KfreeZ closed this Aug 27, 2024
@KfreeZ KfreeZ deleted the deleteUnslessfile branch August 30, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants