-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HPA support to ChatQnA #327
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| # Copyright (C) 2024 Intel Corporation | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| {{- if .Values.global.horizontalPodAutoscaler.enabled }} | ||
| apiVersion: v1 | ||
| data: | ||
| config.yaml: | | ||
| rules: | ||
| - seriesQuery: '{__name__="tgi_request_inference_duration_sum",service="{{ include "tgi.fullname" .Subcharts.tgi }}"}' | ||
| # Average request latency from TGI histograms, over 1 min | ||
| # (0.001 divider add is to make sure there's always a valid value) | ||
| metricsQuery: 'rate(tgi_request_inference_duration_sum{service="{{ include "tgi.fullname" .Subcharts.tgi }}",<<.LabelMatchers>>}[1m]) / (0.001+rate(tgi_request_inference_duration_count{service="{{ include "tgi.fullname" .Subcharts.tgi }}",<<.LabelMatchers>>}[1m]))' | ||
| name: | ||
| matches: ^tgi_request_inference_duration_sum | ||
| as: "tgi_request_latency" | ||
| resources: | ||
| # HPA needs both namespace + suitable object resource for its query paths: | ||
| # /apis/custom.metrics.k8s.io/v1beta1/namespaces/default/service/*/tgi_request_latency | ||
| # (pod is not suitable object type for matching as each instance has different name) | ||
| overrides: | ||
| namespace: | ||
| resource: namespace | ||
| service: | ||
| resource: service | ||
| - seriesQuery: '{__name__="te_request_inference_duration_sum",service="{{ include "teirerank.fullname" .Subcharts.teirerank }}"}' | ||
| # Average request latency from TEI histograms, over 1 min | ||
| metricsQuery: 'rate(te_request_inference_duration_sum{service="{{ include "teirerank.fullname" .Subcharts.teirerank }}",<<.LabelMatchers>>}[1m]) / (0.001+rate(te_request_inference_duration_count{service="{{ include "teirerank.fullname" .Subcharts.teirerank }}",<<.LabelMatchers>>}[1m]))' | ||
| name: | ||
| matches: ^te_request_inference_duration_sum | ||
| as: "reranking_request_latency" | ||
| resources: | ||
| overrides: | ||
| namespace: | ||
| resource: namespace | ||
| service: | ||
| resource: service | ||
| - seriesQuery: '{__name__="te_request_inference_duration_sum",service="{{ include "tei.fullname" .Subcharts.tei }}"}' | ||
| # Average request latency from TEI histograms, over 1 min | ||
| metricsQuery: 'rate(te_request_inference_duration_sum{service="{{ include "tei.fullname" .Subcharts.tei }}",<<.LabelMatchers>>}[1m]) / (0.001+rate(te_request_inference_duration_count{service="{{ include "tei.fullname" .Subcharts.tei }}",<<.LabelMatchers>>}[1m]))' | ||
| name: | ||
| matches: ^te_request_inference_duration_sum | ||
| as: "embedding_request_latency" | ||
| resources: | ||
| overrides: | ||
| namespace: | ||
| resource: namespace | ||
| service: | ||
| resource: service | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: adapter-config | ||
| namespace: monitoring | ||
| {{- end }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
helm-charts/common/tei/templates/horizontalPodAutoscaler.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| # Copyright (C) 2024 Intel Corporation | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| {{- if .Values.global.horizontalPodAutoscaler.enabled }} | ||
| apiVersion: autoscaling/v2 | ||
| kind: HorizontalPodAutoscaler | ||
| metadata: | ||
| name: {{ include "tei.fullname" . }} | ||
| spec: | ||
| scaleTargetRef: | ||
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| name: {{ include "tei.fullname" . }} | ||
| minReplicas: 1 | ||
| maxReplicas: {{ .Values.horizontalPodAutoscaler.maxReplicas }} | ||
| metrics: | ||
| - type: Object | ||
| object: | ||
| metric: | ||
| # tei-embedding time metrics are in seconds | ||
| name: embedding_request_latency | ||
| describedObject: | ||
| apiVersion: v1 | ||
| # get metric for named object of given type (in same namespace) | ||
| kind: Service | ||
| name: {{ include "tei.fullname" . }} | ||
| target: | ||
| # embedding_request_latency is average for all TEI pods. To avoid replica fluctuations when | ||
| # TEI startup + request processing takes longer than HPA evaluation period, this uses | ||
| # "Value" (replicas = metric.value / target.value), instead of "averageValue" type: | ||
| # https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/#algorithm-details | ||
| type: Value | ||
| value: 4 | ||
| behavior: | ||
| scaleDown: | ||
| stabilizationWindowSeconds: 180 | ||
| policies: | ||
| - type: Percent | ||
| value: 25 | ||
| periodSeconds: 15 | ||
| scaleUp: | ||
| selectPolicy: Max | ||
| stabilizationWindowSeconds: 0 | ||
| policies: | ||
| - type: Percent | ||
| value: 50 | ||
| periodSeconds: 15 | ||
| - type: Pods | ||
| value: 2 | ||
| periodSeconds: 15 | ||
| {{- end }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # Copyright (C) 2024 Intel Corporation | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| {{- if .Values.global.horizontalPodAutoscaler.enabled }} | ||
| apiVersion: monitoring.coreos.com/v1 | ||
| kind: ServiceMonitor | ||
| metadata: | ||
| name: {{ include "tei.fullname" . }} | ||
| spec: | ||
| selector: | ||
| matchLabels: | ||
| {{- include "tei.selectorLabels" . | nindent 6 }} | ||
| endpoints: | ||
| - interval: 4s | ||
| port: tei | ||
| scheme: http | ||
| {{- end }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need "HorizontalPodAutoscaler (HPA) support" section in
chatqnaREADME too. It can be same as in common components, with first clause updated e.g. to:Verification section can be omitted I think, it's enough to have it in TGI & TEI READMEs.
Options table entry description could be e.g: