helm: fix tei/tgi/docsum #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue opea-project#286 Signed-off-by: Lianhao Lu <[email protected]>
Fix issue opea-project#287 Signed-off-by: Lianhao Lu <[email protected]>
Signed-off-by: Lianhao Lu <[email protected]>
yongfengdu
approved these changes
Aug 9, 2024
eero-t
reviewed
Aug 28, 2024
Comment on lines
+11
to
+12
| securityContext: | ||
| readOnlyRootFilesystem: false |
There was a problem hiding this comment.
IMHO Instead of allowing rootfs writes, this should have been fixed by adding separate volume for writes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains the following fix and enhancement
Issues
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
n/a.
Tests
Describe the tests that you ran to verify your changes.