Fix router bugs on max_new_tokens and dataprep gaudi yaml file #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhlsunshine <[email protected]>
irisdingbj
reviewed
Aug 6, 2024
Signed-off-by: zhlsunshine <[email protected]>
Signed-off-by: zhlsunshine <[email protected]>
KfreeZ
reviewed
Aug 7, 2024
| } | ||
| // Merge init request into respReq | ||
| for key, value := range initReqData[Parameters].(map[string]interface{}) { | ||
| /*if _, exists := respReqData[key]; !exists { |
There was a problem hiding this comment.
Hi @KfreeZ, just let's keep it there, because let's see if they need to keep the response instead overwriting by initial request.
KfreeZ
reviewed
Aug 7, 2024
| @@ -198,6 +199,32 @@ func executeStep( | |||
| return callService(step, serviceURL, input, headers) | |||
| } | |||
|
|
|||
| func mergeRequests(respReq []byte, initReqData map[string]interface{}) []byte { | |||
There was a problem hiding this comment.
Just curious, why the handleEnsemblePipeline does not need this mergeRequest?
There was a problem hiding this comment.
Hi @KfreeZ, based on current implementation, EnsemblePipeline have no response case, so just let it there.
KfreeZ
approved these changes
Aug 7, 2024
irisdingbj
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix router bugs on max_new_tokens and dataprep gaudi yaml file. And remove
^Mfrom dataprep xeon yaml file.This max_new_tokens bug was found when doing performance test by @leslieluyu
Issues
#272
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
n/a.Tests
Set max_new_tokens=17
Set max_new_tokens=50
