-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: Update helm manifest to address user raised issues #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade image version to cpu-1.5 - Add parameter to handling long retrievals Fix issue opea-project#233. Partial of opea-project#231. Signed-off-by: Lianhao Lu <[email protected]>
Fix bug opea-project#190 Signed-off-by: Lianhao Lu <[email protected]>
Some container images doesn't have a very robust health check mechanism which will cause helm test failing in connecting even with health check is passed. Add the retry mechanism in all helm test to avoid sporadic connection failure in helm test. Signed-off-by: Lianhao Lu <[email protected]>
Related to issue opea-project#218 Signed-off-by: Lianhao Lu <[email protected]>
Also use specific image version instead of latest. Signed-off-by: Lianhao Lu <[email protected]>
Automatically popluate the default endpoint into no_proxy if proxy is set. If users specify the endpoints with their own value, it won't be populated into no_proxy, because we can't assume the user specified endpoints should be accessed through proxy. Fix issue opea-project#225. Signed-off-by: Lianhao Lu <[email protected]>
yongfengdu
approved these changes
Aug 7, 2024
daisy-ycguo
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is aim to address the following user raised issues.
Issues
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
n/a.
Tests
Describe the tests that you ran to verify your changes.