Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Update helm manifest to address user raised issues #267

Merged
merged 6 commits into from
Aug 7, 2024

Conversation

lianhao
Copy link
Collaborator

@lianhao lianhao commented Aug 6, 2024

Description

This PR is aim to address the following user raised issues.

Issues

Type of change

List the type of change like below. Please delete options that are not relevant.

  • New feature (non-breaking change which adds new functionality)

Dependencies

n/a.

Tests

Describe the tests that you ran to verify your changes.

- Upgrade image version to cpu-1.5

- Add parameter to handling long retrievals

Fix issue opea-project#233. Partial of opea-project#231.

Signed-off-by: Lianhao Lu <[email protected]>
Some container images doesn't have a very robust health check mechanism
which will cause helm test failing in connecting even with health check
is passed. Add the retry mechanism in all helm test to avoid sporadic
connection failure in helm test.

Signed-off-by: Lianhao Lu <[email protected]>
Also use specific image version instead of latest.

Signed-off-by: Lianhao Lu <[email protected]>
Automatically popluate the default endpoint into no_proxy if proxy is
set.

If users specify the endpoints with their own value, it won't be
populated into no_proxy, because we can't assume the user specified
endpoints should be accessed through proxy.

Fix issue opea-project#225.

Signed-off-by: Lianhao Lu <[email protected]>
Copy link
Collaborator

@daisy-ycguo daisy-ycguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@daisy-ycguo daisy-ycguo merged commit 4319660 into opea-project:main Aug 7, 2024
35 checks passed
@lianhao lianhao deleted the version branch August 7, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants