Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authN-authZ: update documentation and policy #260

Closed
wants to merge 2 commits into from

Conversation

Ruoyu-y
Copy link
Collaborator

@Ruoyu-y Ruoyu-y commented Aug 5, 2024

Description

  • Add more descriptions for the authentication and authorization part
  • change the sample authorization to perform on role

Issues

n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • [*] Bug fix (non-breaking change which fixes an issue)

Dependencies

n/a

Tests

n/a

@Ruoyu-y
Copy link
Collaborator Author

Ruoyu-y commented Aug 5, 2024

@mkbhanda Please help with review. I add a few more descriptions to make the Keycloak case a sample we provide for OIDC providers and changed the istio authorization policy to work based on role.

@Ruoyu-y Ruoyu-y force-pushed the auth-update branch 2 times, most recently from 8b7d76d to 99a9354 Compare August 6, 2024 00:25
* Add more descriptions for the authentication and authorization part
* change the sample authorization to perform on role

Signed-off-by: Ruoyu Ying <[email protected]>
@hshen14
Copy link
Contributor

hshen14 commented Aug 9, 2024

Adding @ckhened for awareness and review

@Ruoyu-y
Copy link
Collaborator Author

Ruoyu-y commented Aug 19, 2024

Since this PR has already been contained in #291, decide to close here.

@Ruoyu-y Ruoyu-y closed this Aug 19, 2024
@Ruoyu-y Ruoyu-y deleted the auth-update branch August 26, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants