Add docker compose deployment for ROCm example #1054
Conversation
|
Please add a similar CI test like this, so we can trigger the test on amd gpu, https://github.com/opea-project/GenAIExamples/blob/ee87d75876b231a0f290a69d7e21d21aad74a16a/DocSum/tests/test_compose_on_gaudi.sh |
|
And the node from AMD is offline, please check the connect status, |
astafevav
force-pushed
the
add-docsum-rocm-docker-compose-example
branch
from
0e08891
to
7ea3fa8
Compare
|
Hi @chensuyue, thank you for review, I've added test scripts for AMD Rocm for DocSum And FaqGen, But still clarifying status for coresite-sv7-106-amd-mi300-19 with the team. |
astafevav
force-pushed
the
add-docsum-rocm-docker-compose-example
branch
from
7ea3fa8
to
713cc1b
Compare
| @@ -0,0 +1,87 @@ | |||
| # Copyright (C) 2024 Intel Corporation | |||
There was a problem hiding this comment.
I think you should add AMD copyright.
| @@ -0,0 +1,184 @@ | |||
| #!/bin/bash | |||
| # Copyright (C) 2024 Intel Corporation | |||
| security_opt: | ||
| - seccomp:unconfined | ||
| cap_add: | ||
| - SYS_PTRACE |
There was a problem hiding this comment.
Is this some development version not intended for production, or why it's disabling security measures instead of adding them?
|
|
||
| stop_docker | ||
|
|
||
| if [[ "$IMAGE_REPO" == "opea" ]]; then build_docker_images; fi |
There was a problem hiding this comment.
Would be good to make all scripts shellcheck clean (apt install shellscheck; shellcheck *.sh).
Signed-off-by: astafevav <[email protected]>
astafevav
force-pushed
the
add-docsum-rocm-docker-compose-example
branch
from
c96d387
to
e7ae5d1
Compare
Co-authored-by: Eero Tamminen <[email protected]>
Co-authored-by: Eero Tamminen <[email protected]>
Co-authored-by: Eero Tamminen <[email protected]>
|
Hi @chensuyue , @eero-t , I've found that I will need submit PR for AMD activity from my corporate github account. I will close this one, for DocSum and ChatQnA and re-open with all suggested fixes. Still clarifying status for AMD copyright and will fix shellcheck warning for then too. Sorry for inconvenience. |
|
Please also fix the CI issue. |
Please put your new PR link here when you have it and close the old one. |
Re-submitted PR: #1125, I'm still working on test script, so status for new PR is still work in progress. Closing this one. |
|
Re-submitted PR: #1125 |
Type of change