Skip to content

Commit

Permalink
[8.x] [unified_doc_viewer / unified_search] clean up SASS compilation…
Browse files Browse the repository at this point in the history 
… warnings (elastic#198876) (elastic#199052)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[unified_doc_viewer / unified_search] clean up SASS compilation
warnings (elastic#198876)](elastic#198876)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tim
Sullivan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T20:08:05Z","message":"[unified_doc_viewer
/ unified_search] clean up SASS compilation warnings (elastic#198876)\n\n##
Summary\r\n\r\nThis PR cleans up two noisy warnings seen when building
Kibana:\r\n```\r\n[2024-11-04 21:26:37] │ warn worker stderr DEPRECATION
WARNING: Using / for division outside of calc() is deprecated and will
be removed in Dart Sass 2.0.0.\r\n[2024-11-04 21:26:37] │ warn worker
stderr \r\n[2024-11-04 21:26:37] │ warn worker stderr Recommendation:
math.div($euiSizeXS, 2) or calc($euiSizeXS / 2)\r\n[2024-11-04 21:26:37]
│ warn worker stderr \r\n[2024-11-04 21:26:37] │ warn worker stderr More
info and automated migrator:
https://sass-lang.com/d/slash-div\r\n[2024-11-04 21:26:37] │ warn worker
stderr \r\n[2024-11-04 21:26:37] │ warn worker stderr ╷\r\n[2024-11-04
21:26:37] │ warn worker stderr 94 │ padding: $euiSizeXS / 2 0 0
$euiSizeXS;\r\n[2024-11-04 21:26:37] │ warn worker stderr │
^^^^^^^^^^^^^^\r\n[2024-11-04 21:26:37] │ warn worker stderr
╵\r\n[2024-11-04 21:26:37] │ warn worker stderr
file:///home/tim/kibana/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.scss
94:14 root stylesheet\r\n[2024-11-04 21:26:37] │ warn worker stderr
\r\n[2024-11-04 21:35:27] │ warn worker stderr DEPRECATION WARNING:
Using / for division outside of calc() is deprecated and will be removed
in Dart Sass 2.0.0.\r\n[2024-11-04 21:35:27] │ warn worker stderr
\r\n[2024-11-04 21:35:27] │ warn worker stderr Recommendation:
math.div($euiSizeM, 2) or calc($euiSizeM / 2)\r\n[2024-11-04 21:35:27] │
warn worker stderr \r\n[2024-11-04 21:35:27] │ warn worker stderr More
info and automated migrator:
https://sass-lang.com/d/slash-div\r\n[2024-11-04 21:35:27] │ warn worker
stderr \r\n[2024-11-04 21:35:27] │ warn worker stderr ╷\r\n[2024-11-04
21:35:27] │ warn worker stderr 11 │ padding-block: $euiSizeM /
2;\r\n[2024-11-04 21:35:27] │ warn worker stderr │
^^^^^^^^^^^^^\r\n[2024-11-04 21:35:27] │ warn worker stderr
╵\r\n[2024-11-04 21:35:27] │ warn worker stderr
file:///home/tim/kibana/src/plugins/unified_search/public/filter_bar/filter_item/filter_item.scss
11:18 root
stylesheet\r\n```","sha":"7a3a2b3cb8525acca46481508663d6fd98c5b27b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"[unified_doc_viewer
/ unified_search] clean up SASS compilation
warnings","number":198876,"url":"https://github.com/elastic/kibana/pull/198876","mergeCommit":{"message":"[unified_doc_viewer
/ unified_search] clean up SASS compilation warnings (elastic#198876)\n\n##
Summary\r\n\r\nThis PR cleans up two noisy warnings seen when building
Kibana:\r\n```\r\n[2024-11-04 21:26:37] │ warn worker stderr DEPRECATION
WARNING: Using / for division outside of calc() is deprecated and will
be removed in Dart Sass 2.0.0.\r\n[2024-11-04 21:26:37] │ warn worker
stderr \r\n[2024-11-04 21:26:37] │ warn worker stderr Recommendation:
math.div($euiSizeXS, 2) or calc($euiSizeXS / 2)\r\n[2024-11-04 21:26:37]
│ warn worker stderr \r\n[2024-11-04 21:26:37] │ warn worker stderr More
info and automated migrator:
https://sass-lang.com/d/slash-div\r\n[2024-11-04 21:26:37] │ warn worker
stderr \r\n[2024-11-04 21:26:37] │ warn worker stderr ╷\r\n[2024-11-04
21:26:37] │ warn worker stderr 94 │ padding: $euiSizeXS / 2 0 0
$euiSizeXS;\r\n[2024-11-04 21:26:37] │ warn worker stderr │
^^^^^^^^^^^^^^\r\n[2024-11-04 21:26:37] │ warn worker stderr
╵\r\n[2024-11-04 21:26:37] │ warn worker stderr
file:///home/tim/kibana/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.scss
94:14 root stylesheet\r\n[2024-11-04 21:26:37] │ warn worker stderr
\r\n[2024-11-04 21:35:27] │ warn worker stderr DEPRECATION WARNING:
Using / for division outside of calc() is deprecated and will be removed
in Dart Sass 2.0.0.\r\n[2024-11-04 21:35:27] │ warn worker stderr
\r\n[2024-11-04 21:35:27] │ warn worker stderr Recommendation:
math.div($euiSizeM, 2) or calc($euiSizeM / 2)\r\n[2024-11-04 21:35:27] │
warn worker stderr \r\n[2024-11-04 21:35:27] │ warn worker stderr More
info and automated migrator:
https://sass-lang.com/d/slash-div\r\n[2024-11-04 21:35:27] │ warn worker
stderr \r\n[2024-11-04 21:35:27] │ warn worker stderr ╷\r\n[2024-11-04
21:35:27] │ warn worker stderr 11 │ padding-block: $euiSizeM /
2;\r\n[2024-11-04 21:35:27] │ warn worker stderr │
^^^^^^^^^^^^^\r\n[2024-11-04 21:35:27] │ warn worker stderr
╵\r\n[2024-11-04 21:35:27] │ warn worker stderr
file:///home/tim/kibana/src/plugins/unified_search/public/filter_bar/filter_item/filter_item.scss
11:18 root
stylesheet\r\n```","sha":"7a3a2b3cb8525acca46481508663d6fd98c5b27b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198876","number":198876,"mergeCommit":{"message":"[unified_doc_viewer
/ unified_search] clean up SASS compilation warnings (elastic#198876)\n\n##
Summary\r\n\r\nThis PR cleans up two noisy warnings seen when building
Kibana:\r\n```\r\n[2024-11-04 21:26:37] │ warn worker stderr DEPRECATION
WARNING: Using / for division outside of calc() is deprecated and will
be removed in Dart Sass 2.0.0.\r\n[2024-11-04 21:26:37] │ warn worker
stderr \r\n[2024-11-04 21:26:37] │ warn worker stderr Recommendation:
math.div($euiSizeXS, 2) or calc($euiSizeXS / 2)\r\n[2024-11-04 21:26:37]
│ warn worker stderr \r\n[2024-11-04 21:26:37] │ warn worker stderr More
info and automated migrator:
https://sass-lang.com/d/slash-div\r\n[2024-11-04 21:26:37] │ warn worker
stderr \r\n[2024-11-04 21:26:37] │ warn worker stderr ╷\r\n[2024-11-04
21:26:37] │ warn worker stderr 94 │ padding: $euiSizeXS / 2 0 0
$euiSizeXS;\r\n[2024-11-04 21:26:37] │ warn worker stderr │
^^^^^^^^^^^^^^\r\n[2024-11-04 21:26:37] │ warn worker stderr
╵\r\n[2024-11-04 21:26:37] │ warn worker stderr
file:///home/tim/kibana/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.scss
94:14 root stylesheet\r\n[2024-11-04 21:26:37] │ warn worker stderr
\r\n[2024-11-04 21:35:27] │ warn worker stderr DEPRECATION WARNING:
Using / for division outside of calc() is deprecated and will be removed
in Dart Sass 2.0.0.\r\n[2024-11-04 21:35:27] │ warn worker stderr
\r\n[2024-11-04 21:35:27] │ warn worker stderr Recommendation:
math.div($euiSizeM, 2) or calc($euiSizeM / 2)\r\n[2024-11-04 21:35:27] │
warn worker stderr \r\n[2024-11-04 21:35:27] │ warn worker stderr More
info and automated migrator:
https://sass-lang.com/d/slash-div\r\n[2024-11-04 21:35:27] │ warn worker
stderr \r\n[2024-11-04 21:35:27] │ warn worker stderr ╷\r\n[2024-11-04
21:35:27] │ warn worker stderr 11 │ padding-block: $euiSizeM /
2;\r\n[2024-11-04 21:35:27] │ warn worker stderr │
^^^^^^^^^^^^^\r\n[2024-11-04 21:35:27] │ warn worker stderr
╵\r\n[2024-11-04 21:35:27] │ warn worker stderr
file:///home/tim/kibana/src/plugins/unified_search/public/filter_bar/filter_item/filter_item.scss
11:18 root
stylesheet\r\n```","sha":"7a3a2b3cb8525acca46481508663d6fd98c5b27b"}}]}]
BACKPORT-->

Co-authored-by: Tim Sullivan <[email protected]>
  • Loading branch information
@kibanamachine @tsullivan
kibanamachine and tsullivan authored Nov 5, 2024
1 parent 28dcdbf commit 2120e2a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
}

& [data-gridcell-column-id='pin_field'] .euiDataGridRowCell__content {
padding: $euiSizeXS / 2 0 0 $euiSizeXS;
padding: calc($euiSizeXS / 2) 0 0 $euiSizeXS;
}

.kbnDocViewer__fieldsGrid__pinAction {
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/unified_search/public/filter_bar/filter_item/filter_item.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
.globalFilterItem {
line-height: $euiSize;
color: $euiTextColor;
padding-block: $euiSizeM / 2;
padding-block: calc($euiSizeM / 2);
white-space: normal; /* 1 */

&:not(.globalFilterItem-isDisabled) {
Expand Down

0 comments on commit 2120e2a

Please sign in to comment.