Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update msg_template.txt with missing strings #52

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Ro-Borges
Copy link

Update the msg_template.txt with all the missing strings I could find so far

@oomek
Copy link
Owner

oomek commented Oct 13, 2023

There are some entries i your commit that don't exist in the source code
Down (Next Game)
Left (Previous Display)
Right (Next Display)
Up (Previous Game)

Additionaly I've realised that many _help strings aren't even used. There is a long way ahead of us if we want to clean it all up.

@Ro-Borges
Copy link
Author

Ro-Borges commented Oct 14, 2023

There are some entries i your commit that don't exist in the source code Down (Next Game) Left (Previous Display) Right (Next Display) Up (Previous Game)

Additionaly I've realised that many _help strings aren't even used. There is a long way ahead of us if we want to clean it all up.

They are used in the controls option from the main menu and get translated if added to a language file.

My next "job" would be to go through the help messages used and then compare with the ones in the source file

image

image

@oomek
Copy link
Owner

oomek commented Oct 14, 2023

These 5 entries are dynamically constructed from the navigation direction and default action configured inside each direction entry.
For example Up and Previous Game which are already in the translation files.
image

If these are present in some of the translation files that means someone has put them there by mistake.

@oomek
Copy link
Owner

oomek commented Oct 14, 2023

// Show the default action in brackets beside the UI controls (up/down/left...etc)

@Ro-Borges
Copy link
Author

I get it, but even if there is a translation for the individual words, the dinamically combined words don't get translated.

That is why I had to put them in the template

@oomek
Copy link
Owner

oomek commented Oct 14, 2023

You are right. You have just discovered a bug. This should not be like that, because having to provide 39 translations for each of 5 compound controls sounds a bit insane. I'll look into it.

@oomek oomek added the bug Something isn't working label Oct 14, 2023
@oomek
Copy link
Owner

oomek commented Oct 20, 2023

Issue fixed in a8ad0fb
You can now push more commits to this PR consisting only of basic strings.

@@ -25,8 +25,10 @@ Artwork Label;Artwork Label
Artwork Name;Artwork Name
Artwork Path;Artwork Path
Attract-Mode detected emulator(s) that can be imported automatically. Import them now?;Attract-Mode detected emulator(s) that can be imported automatically. Import them now?
Auto-detect emulators?;Auto-detect emulators?
Auto-detect Emulators;Auto-detect Emulators
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm cleaning up the translation files now. Where did you find this line in the code?

@pedrowarlock
Copy link

pedrowarlock commented Feb 26, 2024

Sorry to intrude, but they are two different strings:
You cannot replace one with the other, but add the new one without the "?"

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants