Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors in linux #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

lcinacio
Copy link

@lcinacio lcinacio commented Apr 3, 2018

Added bufferutil & utf-8-validate to package.json. Fixed different case between import statement & file system to prevent build error in linux

…se between import statement & file system to prevent build error in linux
@MickWang
Copy link
Collaborator

MickWang commented Apr 4, 2018

I changed filenames all to start with lower case, but git ignores some files. Then i use 'git config core.ignorecase false' to let git detect the filename change. I will push a commit to solve this problem.
Could you tell me about why you need to add bufferutil & utf-8-validate?

MickWang pushed a commit to MickWang/ontology-ts-sdk that referenced this pull request Apr 4, 2018
MickWang added a commit that referenced this pull request Apr 4, 2018
* update some test;fix issue1;fix pr #7

* update tsconfig.json for build amd file
@lcinacio
Copy link
Author

lcinacio commented Apr 4, 2018

Without adding bufferutil & utf-8-validate to package.json I get the warnings below:
WARNING in ./node_modules/ws/lib/buffer-util.js
Module not found: Error: Can't resolve 'bufferutil' in 'C:\Users\luizi\ontology-ts-sdk\node_modules\ws\lib'
resolve 'bufferutil' in 'C:\Users\luizi\ontology-ts-sdk\node_modules\ws\lib'
Parsed request is a module
using description file: C:\Users\luizi\ontology-ts-sdk\node_modules\ws\package.json (relative path: ./lib)
after using description file: C:\Users\luizi\ontology-ts-sdk\node_modules\ws\package.json (relative path: ./lib)
resolve as module
C:\Users\luizi\ontology-ts-sdk\node_modules\ws\lib\node_modules doesn't exist or is not a directory
C:\Users\luizi\ontology-ts-sdk\node_modules\ws\node_modules doesn't exist or is not a directory
C:\Users\luizi\ontology-ts-sdk\node_modules\node_modules doesn't exist or is not a directory
C:\Users\luizi\node_modules doesn't exist or is not a directory
C:\Users\node_modules doesn't exist or is not a directory
C:\node_modules doesn't exist or is not a directory
looking for modules in C:\Users\luizi\ontology-ts-sdk\node_modules
using description file: C:\Users\luizi\ontology-ts-sdk\package.json (relative path: ./node_modules)
after using description file: C:\Users\luizi\ontology-ts-sdk\package.json (relative path: ./node_modules)
using description file: C:\Users\luizi\ontology-ts-sdk\package.json (relative path: ./node_modules/bufferutil)
no extension
C:\Users\luizi\ontology-ts-sdk\node_modules\bufferutil doesn't exist
.ts
C:\Users\luizi\ontology-ts-sdk\node_modules\bufferutil.ts doesn't exist
.js
C:\Users\luizi\ontology-ts-sdk\node_modules\bufferutil.js doesn't exist
as directory
C:\Users\luizi\ontology-ts-sdk\node_modules\bufferutil doesn't exist

WARNING in ./node_modules/ws/lib/validation.js
Module not found: Error: Can't resolve 'utf-8-validate' in 'C:\Users\luizi\ontology-ts-sdk\node_modules\ws\lib'
resolve 'utf-8-validate' in 'C:\Users\luizi\ontology-ts-sdk\node_modules\ws\lib'
  Parsed request is a module
  using description file: C:\Users\luizi\ontology-ts-sdk\node_modules\ws\package.json (relative path: ./lib)
  after using description file: C:\Users\luizi\ontology-ts-sdk\node_modules\ws\package.json (relative path: ./lib)
    resolve as module
      C:\Users\luizi\ontology-ts-sdk\node_modules\ws\lib\node_modules doesn't exist or is not a directory
      C:\Users\luizi\ontology-ts-sdk\node_modules\ws\node_modules doesn't exist or is not a directory
      C:\Users\luizi\ontology-ts-sdk\node_modules\node_modules doesn't exist or is not a directory
      C:\Users\luizi\node_modules doesn't exist or is not a directory
      C:\Users\node_modules doesn't exist or is not a directory
      C:\node_modules doesn't exist or is not a directory
      looking for modules in C:\Users\luizi\ontology-ts-sdk\node_modules
        using description file: C:\Users\luizi\ontology-ts-sdk\package.json (relative path: ./node_modules)
        after using description file: C:\Users\luizi\ontology-ts-sdk\package.json (relative path: ./node_modules)
          using description file: C:\Users\luizi\ontology-ts-sdk\package.json (relative path: ./node_modules/utf-8-validate)
            no extension
              C:\Users\luizi\ontology-ts-sdk\node_modules\utf-8-validate doesn't exist
            .ts
              C:\Users\luizi\ontology-ts-sdk\node_modules\utf-8-validate.ts doesn't exist
            .js
              C:\Users\luizi\ontology-ts-sdk\node_modules\utf-8-validate.js doesn't exist
            as directory
              C:\Users\luizi\ontology-ts-sdk\node_modules\utf-8-validate doesn't exist

backslash47 added a commit to backslash47/ontology-ts-sdk that referenced this pull request Apr 7, 2018
backslash47 added a commit to backslash47/ontology-ts-sdk that referenced this pull request Apr 7, 2018
backslash47 added a commit to backslash47/ontology-ts-sdk that referenced this pull request Apr 7, 2018
backslash47 added a commit to backslash47/ontology-ts-sdk that referenced this pull request Apr 7, 2018
MickWang pushed a commit that referenced this pull request Apr 8, 2018
* Revert " update some test;fix issue1;fix pr #7 (#8)"

This reverts commit 098d4f4.

* renaming files with wrong case to support linux build

Signed-off-by: Matus Zamborsky <[email protected]>

* reapply changes from reverted commit "update some test;fix issue1;fix pr #7 (#8)"

Signed-off-by: Matus Zamborsky <[email protected]>
MickWang added a commit that referenced this pull request Apr 9, 2018
* update some test;fix issue1;fix pr #7

* update tsconfig.json for build amd file

* add verify ontid claim; add ontidContract tx

* update ontid contract

* update tsconfig.json compile option
MickWang added a commit that referenced this pull request Apr 11, 2018
* update some test;fix issue1;fix pr #7

* update tsconfig.json for build amd file

* add verify ontid claim; add ontidContract tx

* update ontid contract

* update tsconfig.json compile option

* add restful,rpc,websocket api
MickWang added a commit that referenced this pull request Apr 16, 2018
* update some test;fix issue1;fix pr #7

* update tsconfig.json for build amd file

* add verify ontid claim; add ontidContract tx

* update ontid contract

* update tsconfig.json compile option

* add restful,rpc,websocket api
MickWang pushed a commit to MickWang/ontology-ts-sdk that referenced this pull request Apr 16, 2018
MickWang added a commit that referenced this pull request Apr 25, 2018
* update some test;fix issue1;fix pr #7

* update tsconfig.json for build amd file

* add verify ontid claim; add ontidContract tx

* update ontid contract

* update tsconfig.json compile option

* add restful,rpc,websocket api

* update invoke tx serialize

* construct claim proof

* add get proof root

* add wasm support

* add record contract
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants