Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy warnings about unsupported han #769

Open
wants to merge 1 commit into
base: tf-1.x
Choose a base branch
from

Conversation

IlyaOvodov
Copy link

Now onnx-tf generate warnings "Unknown op {} in domain {}" and "Fail to get since_version of {} in domain {}" during loading handlers for all handlers that cause these warning regardless off are these handlers required to process the ONNX file at hands. It always produces problems with ConstantFill and ImageScaler handlers resulting in issues like #736, #720, #711, #701, #692, #691, #557. Actually all these warnings are useless it these handlers are not actually used. But they confuses user as if his model can't be converted correctly. Now warnings are changet to INFO, but still does not tell if they are importent or useless.

I propose to display these warnings only in case if specific handler is used in ONNX file being converted.

@CLAassistant
Copy link

CLAassistant commented Sep 24, 2020

CLA assistant check
All committers have signed the CLA.

@lgtm-com
Copy link

lgtm-com bot commented Sep 24, 2020

This pull request introduces 2 alerts when merging 6835315 into 6b9e76d - view on LGTM.com

new alerts:

  • 2 for Unused import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants