-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch for --EmitJNI on windows #2582
base: main
Are you sure you want to change the base?
Conversation
part 1 of emitjni on windows Signed-off-by: Yu Gong <[email protected]>
part 2 of emitjni on windows Signed-off-by: Yu Gong <[email protected]>
Can one of the admins verify this patch? |
@jenkins-droid test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I am not an expert. Requested @gongsu832 to double check as he is the one that developed this code.
Thanks for the quick fix.
please run the clang format on the modified files. |
For the
These tests are currently not run on the Windows CI. |
yeah, try run these tests manually, but the tests themself are no go. |
@armgong adding these tests is key to make sure your patch continues to work. Would be great if you could look into adding them permanently once you have a clean build with these additional tests. We have no window servers where we can try this out, so we are reliant on you to perform this task. Your effort is much appreciated. |
@AlexandreEichenberger |
@armgong Were you still working on this PR? :) |
sorry, busy for other things, have no time to mod and finished the test |
this naive fix for the issue 2580 https://github.com/onnx/onnx-mlir/issues/2580
test with add.onnx on windows (jdk 11.0)