Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruff config to enable more checks and run auto-fix 2/2 #19

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

justinchuby
Copy link
Contributor

@justinchuby justinchuby commented Jun 4, 2024

Type of Change

Better engineering / linting

Description

This is the 2/2 of the series of PRs enabling ruff to match what the ONNX project has.

  • Update ruff config to enable more checks to have parity with the ONNX project and run auto-fix.
  • For the non-auto-fixable lint errors I added noqa inline for future readers to fix.

Expected Behavior & Potential Risk

Auto-fixed code should be correct, but they need to be guarded with CI.

@justinchuby justinchuby requested a review from chensuyue June 4, 2024 22:59
@justinchuby justinchuby changed the title Update ruff config to enable more checks and run auto-fix Update ruff config to enable more checks and run auto-fix 2/2 Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant