Bug at smooth_temp_ends in jasmine #280
Merged
+17
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #263
In GPS summary measures we smooth out the ends of a trajectory to be within a given day. This can mean either expanding or shrinking the time range (start and end points) to match the start and end of a day. This bug occurs when we expand the time range, but the start or end points we expand are marked as observed, but if that's the case they should be labelled as imputed, since the expansion is no longer observed.
This is identified by checking whether p0 or p1 are larger than 1, thus indicating that the time range is expanded and not shrunk.