Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address FutureWarnings in Sycamore #264

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

hackdna
Copy link
Member

@hackdna hackdna commented Oct 28, 2024

  /home/runner/work/forest/forest/forest/sycamore/common.py:417: FutureWarning: Series.fillna with 'method' is deprecated and will raise in a future version. Use obj.ffill() or obj.bfill() instead.
    df_merged["config_id_update"] = df_merged["config_id"].fillna(

forest/sycamore/tests/test_functions.py::test_summarize_submits_hour
  /home/runner/work/forest/forest/forest/sycamore/submits.py:528: FutureWarning: 'H' is deprecated and will be removed in a future version, please use 'h' instead.
    submits["delivery_time_floor"] = submits["delivery_time"].dt.floor("H")

@hackdna hackdna added the technical debt Cruft and maintenance issues label Oct 28, 2024
@hackdna hackdna merged commit 47bb39e into develop Oct 29, 2024
4 checks passed
@hackdna hackdna deleted the sycamore-futurewarnings branch October 29, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical debt Cruft and maintenance issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants