Don't check against empty timings array #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@biblicabeebli it looks like this PR is failing tests for type checking, but I definitely did not change anything related to types. Do you know what the current process is for merging code with failed checks? Should we merge this in even if the checks fail or do we need to fix all of the old code? |
|
Hi @clementzach, thanks for the bug fix. Those errors are about the correct use of NaN constant which is |
|
I fixed the mypy errors but we are now blocked by #210. I am working on a fix with @MStraczkiewicz and @GeorgeEfstathiadis. |
hackdna
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an error that happened when checking against an empty survey timings submits array