-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional frequency names #227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this is cleaner but why do these need to be additional instead of replacement?
Discussed this with JP, and agreed it's better this way because we have studies running their pipelines using forest. If we change this we would have to send out an alert for this to all study teams using this, which is not something we want to do right now, thus we only add the cleaner version on top of the other and just change MINUTELY to MINUTE. |
The code in the How and where are these studies running? Why are they not using the stable |
I think it's because I think for this it still makes sense to just add more options on top, because either |
I just added pull request #228 and I believe the code in my branch is better suited than existing code for adding additional frequency options. The tl;dr is the 4 updated main functions for Willow, Sycamore, and Jasmine now iterate over a list of frequencies, which also stcks output into well-named folders. The current code scrap I used is if submits_timeframe == Frequency.HOURLY_AND_DAILY:
submits_timeframes = [Frequency.HOURLY, Frequency.DAILY]
else:
submits_timeframes = [submits_timeframe] We can easily write a function that decomposes any of the multiple time options into their component list. |
@GeorgeEfstathiadis I see. We need to be careful with what we put in production so that we can maintain development velocity and avoid unnecessary technical debt. I think JP, you, and I (and @biblicabeebli if interested) should chat about this. For this PR lets just rename |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Adding more
Frequency
names for better readability.