Avoid using the root logger (#229)

onnela-lab · Dec 3, 2023 · e8fa411 · e8fa411
1 parent 5cf03af
commit e8fa411
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 19 deletions.
diff --git a/docs/source/logging.md b/docs/source/logging.md
@@ -37,13 +37,6 @@ import logging
 logger = logging.getLogger(__name__)
 ```
 
-Or like this:
-
-```
-from logging import getLogger
-logger = getLogger(__name__)
-```
-
 ## 3. How to insert log messages into definitions
 
 Basic `logging` messages:

diff --git a/forest/bonsai/simulate_gps_data.py b/forest/bonsai/simulate_gps_data.py
@@ -27,8 +27,8 @@
 TRAVELLING_STATUS_LIST = range(11)
 
 
-logging.basicConfig(level=logging.INFO)
-logger = logging.getLogger()
+logger = logging.getLogger(__name__)
+logger.setLevel(logging.INFO)
 
 
 class PossibleExits(Enum):

diff --git a/forest/jasmine/data2mobmat.py b/forest/jasmine/data2mobmat.py
@@ -15,8 +15,8 @@
 TOLERANCE = 1e-6
 
 
-logging.basicConfig(level=logging.INFO)
-logger = logging.getLogger()
+logger = logging.getLogger(__name__)
+logger.setLevel(logging.INFO)
 
 
 def cartesian(

diff --git a/forest/jasmine/mobmat2traj.py b/forest/jasmine/mobmat2traj.py
@@ -13,8 +13,8 @@
 from .data2mobmat import great_circle_dist, exist_knot
 
 
-logging.basicConfig(level=logging.INFO)
-logger = logging.getLogger()
+logger = logging.getLogger(__name__)
+logger.setLevel(logging.INFO)
 
 
 # the details of the functions are in paper [Liu and Onnela (2020)]

diff --git a/forest/jasmine/sogp_gps.py b/forest/jasmine/sogp_gps.py
@@ -14,8 +14,8 @@
 import numpy as np
 
 
-logging.basicConfig(level=logging.INFO)
-logger = logging.getLogger()
+logger = logging.getLogger(__name__)
+logger.setLevel(logging.INFO)
 
 
 def calculate_k0(x1: np.ndarray, x2: np.ndarray, pars: list) -> float:

diff --git a/forest/jasmine/traj2stats.py b/forest/jasmine/traj2stats.py
@@ -32,8 +32,8 @@
 from forest.utils import get_ids
 
 
-logging.basicConfig(level=logging.INFO)
-logger = logging.getLogger()
+logger = logging.getLogger(__name__)
+logger.setLevel(logging.INFO)
 
 
 @dataclass

diff --git a/forest/willow/log_stats.py b/forest/willow/log_stats.py
@@ -17,8 +17,8 @@
 )
 
 
-logging.basicConfig(level=logging.INFO)
-logger = logging.getLogger()
+logger = logging.getLogger(__name__)
+logger.setLevel(logging.INFO)
 
 
 def text_analysis(