Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State refactoring #92

Merged
merged 17 commits into from
Aug 2, 2023
Merged

State refactoring #92

merged 17 commits into from
Aug 2, 2023

Commits on Aug 2, 2023

  1. First prototype of new state management

    @grote
    grote committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    77fbdd7 View commit details
    Browse the repository at this point in the history

  2. cleanup state management after review

    @grote
    grote committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    7bbd605 View commit details
    Browse the repository at this point in the history

  3. Show exception message in UI to aid with debugging errors

    @grote
    grote committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    1c7d484 View commit details
    Browse the repository at this point in the history

  4. Handle Tor errors while starting

    @grote
    grote committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    b2f1888 View commit details
    Browse the repository at this point in the history

  5. Handle zipping error by removing offending file 

    and let user try again
    @grote
    grote committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    5f9faa2 View commit details
    Browse the repository at this point in the history

  6. Fix UI handling of ErrorAddingFile state 

    We weren't properly showing the empty state when the last file got removed.
    @grote
    grote committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    03f46f9 View commit details
    Browse the repository at this point in the history

  7. Remove left-over state handling block 

    and add missing NotificationManager calls.
    @grote
    grote committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    1ca1475 View commit details
    Browse the repository at this point in the history

  8. Consume ZipResult with when statement 

    to benefit from its exhaustive nature.
    @grote
    grote committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    56cc2da View commit details
    Browse the repository at this point in the history

  9. Add more logging and don't disable tor bridges on new auto-start 

    as TorWrapper starts with a fresh config each time and doesn't use bridges by default
    @grote
    grote committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    4117d4c View commit details
    Browse the repository at this point in the history

  10. Guard against concurrent modifications of TorState

    @grote
    grote committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    5175a60 View commit details
    Browse the repository at this point in the history

  11. Don't stop if starting Tor was cancelled already

    @grote
    grote committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    c8f8385 View commit details
    Browse the repository at this point in the history

  12. Fix race when stopping Tor

    @grote
    grote committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    e90a022 View commit details
    Browse the repository at this point in the history

  13. Reset progress when waiting for Tor 

    Also write first tests for TorManager
    @grote
    grote committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    5c8829e View commit details
    Browse the repository at this point in the history

  14. Allow cancelling while adding a file to the ZIP as well

    @grote
    grote committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    9ce8815 View commit details
    Browse the repository at this point in the history

  15. Fix display/copy of onion address

    @grote
    grote committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    b2a2515 View commit details
    Browse the repository at this point in the history

  16. Fix empty state condition

    @grote
    grote committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    60d770f View commit details
    Browse the repository at this point in the history

  17. Introduce a Started TorState 

    This is because previously we only considered uploading the HS desc as started. However, this only happens after zipping files. If we zipping takes a long time, Tor would think it hasn't started and tries circumvention methods. Using a new Started state prevents this.
    @grote
    grote committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    49ffd78 View commit details
    Browse the repository at this point in the history