Automatic rewards upgrade tx #238
Conversation
joshuahannan
changed the title
joshuahannan
requested review from
Kay-Zee,
bjartek,
vishalchangrani,
jordanschalm,
KshitijChaudhary666 and
peterargue
|
|
||
| ## Sequence of signing: | ||
|
|
||
| 1. DapperLabs generates the Signature Request ID on the [site]() for the `upgrade_and_enable_rewards.cdc` transaction with the given args. |
There was a problem hiding this comment.
For contract upgrades, the generated URL contains the encoded contract text which is very long, and the browser throws a "URL too long" error.
Hence, for such upgrades, I copy past the args manually instead of generating a prepopulated URL link.
Will do the same this Wednesday.
| @@ -0,0 +1,38 @@ | |||
| # Update FlowIDTableStaking Contract | |||
There was a problem hiding this comment.
Could we document where the bonusTokenAmount argument value came from?
There was a problem hiding this comment.
Yep, I added that to the README
|
|
||
| // Set the new payout in the staking contract and proposed Epoch Metadata | ||
| self.borrowStakingAdmin().setEpochTokenPayout(proposedPayout) | ||
| let proposedMetadata = self.getEpochMetadata(self.proposedEpochCounter()) |
There was a problem hiding this comment.
could this not be done way sooner to avoid doing lots of computation if it fails?
There was a problem hiding this comment.
Can you elaborate? I'm not sure what you want to be done sooner here
There was a problem hiding this comment.
Line 517 panics if it cannot borrow
|
@bjartek The https://github.com/onflow/flow-core-contracts/blob/master/contracts/epochs/FlowEpoch.cdc#L346-L379 Line 360 is were rewards are paid automatically |
transactions/update-contract/2023/may-3-rewards/upgrade_and_enable_rewards.cdc
Outdated
Show resolved
Hide resolved
…able_rewards.cdc Co-authored-by: Peter Argue <[email protected]>
Ok. Will this advanceBlock() block for a long while when processing this payout or is it up? The reason i ask is that i have seen very different seal times for blocks where the payout tx is beeing called. |
|
|
This has been implemented (on 5/3). See the following PRs - onflow/service-account#238 onflow/flow-core-contracts#352 onflow/flow-core-contracts#365
This has been implemented (on 5/3). See the following PRs - onflow/service-account#238 onflow/flow-core-contracts#352 onflow/flow-core-contracts#365
This has been implemented (on 5/3). See the following PRs - onflow/service-account#238 onflow/flow-core-contracts#352 onflow/flow-core-contracts#365
Adds the plan for the transaction to upgrade the
FlowEpochcontract and enable automatic rewards.Also updates the reset epoch transaction to not include the rewards arguments