add additional helper funcs to flowkit and services #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianthpun
requested review from
Kay-Zee,
janezpodhostnik,
sideninja,
chasefleming,
nvdtf and
jribbink
as code owners
6 tasks
ianthpun
commented
Feb 16, 2024
| @@ -79,46 +77,39 @@ type MockServices struct { | |||
| } | |||
|
|
|||
| func DefaultMockServices() *MockServices { | |||
| ctx := context.Background() | |||
There was a problem hiding this comment.
this was a bug as we didn't actually add the ctx into services @bjartek
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
jribbink
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added
ReplaceImportsInScript(context.Context, Script) (Script, error)which will return a script that has the imports replaced with known contract addresses within the networkadd
AccountByContractNameandContractAddresshelper functions in state