Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Get protocol snapshot by block id and block height #1401

Conversation

AndriiDiachuk
Copy link
Contributor

onflow/flow-go#4869

This pull request introduces two new requests for protocol state related to new methods GetProtocolStateSnapshotByBlockID and GetProtocolStateSnapshotByHeight.

@AndriiDiachuk AndriiDiachuk changed the title Andrii diachuk/4869 get protocol snapshot from any block endpoint [Access] Get protocol snapshot by block id and block height Nov 9, 2023
Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, but you'll need rpc definitions for the new methods as well

@AndriiDiachuk
Copy link
Contributor Author

Looks good so far, but you'll need rpc definitions for the new methods as well

Sorry, my bad. Added rpc definitions.

@durkmurder durkmurder merged commit 8e40789 into onflow:master Nov 21, 2023
1 check passed
@AndriiDiachuk AndriiDiachuk deleted the AndriiDiachuk/4869-get-protocol-snapshot-from-any-block-endpoint branch November 21, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants