Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flix and test generic transactions #226

Merged
merged 1 commit into from
Jul 11, 2024
Merged

add flix and test generic transactions #226

merged 1 commit into from
Jul 11, 2024

Conversation

joshuahannan
Copy link
Member

Closes: #222

Description

  • Adds assertions to generic_transfer_with_address to make sure the vault is the correct type
  • Added a test with MaliciousNFT to test the transaction. MaliciousNFT is the same as ExampleNFT, but returns the ExampleNFT paths in the NFTCollectionData view instead of its own paths.
  • Adds FLIX to the main generic transactions
  • Updates comments in NonFungibleToken
  • adds generic_transfer_with_address_and_type since some NFTs might not have the type NFT

I can't think of any other assertions to put in the transactions, but I am open to suggestions


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@joshuahannan joshuahannan added documentation Improvements or additions to documentation Technical Debt SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board labels Jul 9, 2024
Copy link
Collaborator

@sisyphusSmiling sisyphusSmiling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additions!

@joshuahannan joshuahannan merged commit e7a09d9 into master Jul 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board Technical Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put assertions and post-conditions in the generic transactions
2 participants