Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting up script loader for Cadence scripts #64

Merged
merged 10 commits into from
Jul 19, 2024
Merged

Conversation

lealobanov
Copy link
Collaborator

@lealobanov lealobanov commented Jul 18, 2024

Description

  • Setup Cadence scripts to load from external files instead of inline strings

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link

coderabbitai bot commented Jul 18, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Jul 18, 2024

Java Example Unit Test Results

1 files  ±0  1 suites  ±0   1s ⏱️ ±0s
3 tests ±0  3 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0ede393. ± Comparison against base commit ca99408.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 18, 2024

Kotlin Example Unit Test Results

1 files  ±0  1 suites  ±0   1s ⏱️ ±0s
3 tests ±0  3 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0ede393. ± Comparison against base commit ca99408.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 18, 2024

Unit Test Results

  51 files  ±0    51 suites  ±0   20s ⏱️ -1s
275 tests ±0  275 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0ede393. ± Comparison against base commit ca99408.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 18, 2024

Integration Test Results

  7 files  ±0    7 suites  ±0   2m 10s ⏱️ +11s
33 tests ±0  33 ✔️ +3  0 💤 ±0  0 ❌  - 3 

Results for commit 0ede393. ± Comparison against base commit ca99408.

♻️ This comment has been updated with latest results.

@lealobanov lealobanov marked this pull request as ready for review July 18, 2024 12:39
Copy link

@franklywatson franklywatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Cadence file refactor looks great! Much cleaner and nicer to work with now. We can start updating the Cadence files to C1.0 once this change is merged

@lealobanov
Copy link
Collaborator Author

Great, thanks! I will follow up with similar changes for the inlined JSON as well.

@lealobanov lealobanov merged commit 4c47f74 into examples Jul 19, 2024
7 checks passed
@lealobanov lealobanov deleted the cadence-files branch July 21, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants