Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#111, #113/ Updating models related to FlowBlock #120

Merged
merged 13 commits into from
Oct 16, 2024

Conversation

lealobanov
Copy link
Collaborator

@lealobanov lealobanov commented Oct 15, 2024

Closes: #111, #113

Description

Issue #111

  • Update protobuf schema for FlowBlock model
  • Update unit tests for FlowBlock and existing unit tests affected by model changes
  • Update builder methods for FlowBlock and all affected downstream classes
  • Create new model to support FlowExecutionReceiptMeta
  • Add unit tests for FlowExecutionReceiptMeta

Issue #113

  • Update protobuf schema for FlowBlockHeader model
  • Add unit tests for FlowBlockHeader
  • Create new model to support FlowTimeoutCertificate
  • Create new model to support FlowQuorumCertificate
  • Add unit tests for FlowQuorumCertificateand FlowTimeoutCertificate

Add unit tests for classes that were missing tests

  • FlowBlockHeader
  • FlowExecutionResult
  • FlowChunk

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link

github-actions bot commented Oct 15, 2024

SDK Examples Unit Test Results

17 files   - 20  17 suites   - 20   2m 49s ⏱️ - 3m 25s
33 tests  - 37  32 ✔️  - 37  0 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 4636c3d. ± Comparison against base commit fbd0e87.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 15, 2024

Common Integration Test Results

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4636c3d. ± Comparison against base commit fbd0e87.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 15, 2024

Unit Test Results

  60 files  +  6    60 suites  +6   24s ⏱️ -1s
341 tests +25  341 ✔️ +25  0 💤 ±0  0 ❌ ±0 

Results for commit 4636c3d. ± Comparison against base commit fbd0e87.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 15, 2024

Integration Test Results

  6 files  +  6    6 suites  +6   2m 40s ⏱️ + 2m 40s
31 tests +31  30 ✔️ +30  0 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 4636c3d. ± Comparison against base commit fbd0e87.

♻️ This comment has been updated with latest results.

@lealobanov lealobanov changed the title WIP: Updating models related to FlowBlock #111, #113/ Updating models related to FlowBlock Oct 15, 2024
@lealobanov lealobanov marked this pull request as ready for review October 15, 2024 16:28
@lealobanov lealobanov merged commit 9680355 into update-collection-guarantee-protobuf Oct 16, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants