-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Improve error messages when querying old blocks #6554
[Access] Improve error messages when querying old blocks #6554
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6554 +/- ##
=======================================
Coverage 41.12% 41.13%
=======================================
Files 2031 2031
Lines 179589 179611 +22
=======================================
+ Hits 73862 73875 +13
- Misses 99521 99528 +7
- Partials 6206 6208 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Closes: #4904
Context
This PR improves error messaging on Access nodes for block height-based queries:
ExecuteScriptAtBlockHeight
,GetBlockByHeight
,GetBlockHeaderByHeight
,GetEventsForHeightRange
,GetAccountAtBlockHeight
,GetAccountBalanceAtBlockHeight
,GetAccountKeyAtBlockHeight
,GetAccountKeysAtBlockHeight
.Errors are now categorized based on the queried height:
Spork Root Height:
Instructs the caller to use a historic node.Node’s Root Height:
Suggests querying a different Access node (if the node was started after a spork).Updated and added unit tests to validate the new messaging logic.