Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BFT] model.Proposal refactoring #6526

Merged
merged 17 commits into from
Oct 26, 2024
Merged

Conversation

durkmurder
Copy link
Member

#6517

Context

This PR implements refactoring of model.Proposal, all details are in attached issue. This PR very closes follows proposed solution.

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 76.10619% with 27 lines in your changes missing coverage. Please review.

Project coverage is 41.45%. Comparing base (c1a1cc0) to head (78dd10d).

Files with missing lines Patch % Lines
consensus/recovery/recover.go 20.00% 4 Missing ⚠️
consensus/hotstuff/mocks/vote_aggregator.go 0.00% 3 Missing ⚠️
consensus/hotstuff/mocks/validator.go 0.00% 2 Missing ⚠️
consensus/hotstuff/mocks/vote_processor_factory.go 50.00% 0 Missing and 2 partials ⚠️
consensus/hotstuff/mocks/event_handler.go 50.00% 0 Missing and 1 partial ⚠️
consensus/hotstuff/mocks/event_loop.go 0.00% 1 Missing ⚠️
consensus/hotstuff/mocks/participant_consumer.go 0.00% 1 Missing ⚠️
consensus/hotstuff/mocks/safety_rules.go 75.00% 0 Missing and 1 partial ⚠️
...sensus/hotstuff/mocks/vote_aggregation_consumer.go 0.00% 1 Missing ⚠️
...stuff/mocks/vote_aggregation_violation_consumer.go 0.00% 1 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6526      +/-   ##
==========================================
+ Coverage   41.28%   41.45%   +0.17%     
==========================================
  Files        2050     2022      -28     
  Lines      182574   181034    -1540     
==========================================
- Hits        75375    75049     -326     
+ Misses     100870    99711    -1159     
+ Partials     6329     6274      -55     
Flag Coverage Δ
unittests 41.45% <76.10%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

consensus/hotstuff/forks/forks.go Outdated Show resolved Hide resolved
consensus/hotstuff/model/errors.go Outdated Show resolved Hide resolved
consensus/hotstuff/pacemaker/pacemaker.go Outdated Show resolved Hide resolved
consensus/hotstuff/pacemaker/view_tracker.go Outdated Show resolved Hide resolved
Copy link
Member

@AlexHentschel AlexHentschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool. Thanks for the cleanup. Mostly minor comments regarding documentation.

consensus/hotstuff/model/proposal.go Show resolved Hide resolved
consensus/hotstuff/model/proposal.go Show resolved Hide resolved
consensus/hotstuff/model/proposal.go Outdated Show resolved Hide resolved
consensus/hotstuff/eventhandler/event_handler_test.go Outdated Show resolved Hide resolved
consensus/hotstuff/verification/combined_signer_v2_test.go Outdated Show resolved Hide resolved
consensus/hotstuff/verification/combined_signer_v3_test.go Outdated Show resolved Hide resolved
consensus/hotstuff/votecollector/statemachine_test.go Outdated Show resolved Hide resolved
@AlexHentschel AlexHentschel added this pull request to the merge queue Oct 26, 2024
Merged via the queue into master with commit be15d03 Oct 26, 2024
55 checks passed
@AlexHentschel AlexHentschel deleted the yurii/6517-proposal-refactoring branch October 26, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants