-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Add util command to backfill tx error messages db #6525
Draft
UlyanaAndrukhiv
wants to merge
34
commits into
onflow:master
Choose a base branch
from
The-K-R-O-K:UlyanaAndrukhiv/6413-backfill-tx-error-messages
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[Access] Add util command to backfill tx error messages db #6525
UlyanaAndrukhiv
wants to merge
34
commits into
onflow:master
from
The-K-R-O-K:UlyanaAndrukhiv/6413-backfill-tx-error-messages
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…BlockID, backend and ingestion engine, updated tests
… of github.com:The-K-R-O-K/flow-go into UlyanaAndrukhiv/6413-backfill-tx-error-messages
…sages' of github.com:The-K-R-O-K/flow-go into UlyanaAndrukhiv/6497-refactor-executionNodesForBlockID
… of github.com:The-K-R-O-K/flow-go into UlyanaAndrukhiv/6413-backfill-tx-error-messages
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6525 +/- ##
==========================================
+ Coverage 41.14% 41.21% +0.06%
==========================================
Files 2036 2038 +2
Lines 179997 180121 +124
==========================================
+ Hits 74060 74236 +176
+ Misses 99720 99647 -73
- Partials 6217 6238 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
… of github.com:The-K-R-O-K/flow-go into UlyanaAndrukhiv/6413-backfill-tx-error-messages
… of github.com:The-K-R-O-K/flow-go into UlyanaAndrukhiv/6413-backfill-tx-error-messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6413
Note: #6468 and #6499 should be merged first.
Context
This pull request introduces a utility command that allows ANs to backfill missing transaction error messages from start to end height and a set of ENs to their local databases. This ensures that historical ANs have the necessary data to serve requests moving forward.
The command accepts a list of EN IDs (
execution-node-ids
) , if not provided, it defaults to query any available EN. It optionally takes a start and end block height (start-height
,end-height
); if not provided, it defaults to theroot block
andlatest sealed block
.Before execution, the command checks if AN indexing is enabled. For each failed transaction within the block range, it retrieves and stores the error messages locally. It queries ENs in order and stops after the first successful response.
The command uses
GetTransactionErrorMessagesByBlockID
for optimized batch retrieval.Unit tests are included to ensure functionality.