Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeout certificate can be nil #790

Conversation

illia-malachyn
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 57.03%. Comparing base (9f84549) to head (1221b62).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
access/grpc/convert/convert.go 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #790      +/-   ##
==========================================
- Coverage   57.04%   57.03%   -0.01%     
==========================================
  Files          35       35              
  Lines        7391     7392       +1     
==========================================
  Hits         4216     4216              
- Misses       2673     2674       +1     
  Partials      502      502              
Flag Coverage Δ
unittests 57.03% <28.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@illia-malachyn
Copy link
Contributor Author

illia-malachyn commented Oct 22, 2024

@turbolent turbolent requested a review from a team October 22, 2024 14:39
@turbolent turbolent merged commit 175b6cf into onflow:master Oct 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants