Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribe block digest endpoints #764

Merged
merged 15 commits into from
Oct 15, 2024

Conversation

AndriiDiachuk
Copy link
Contributor

Part of #746.

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 63.95349% with 31 lines in your changes missing coverage. Please review.

Project coverage is 55.62%. Comparing base (7b58582) to head (aa96690).
Report is 35 commits behind head on master.

Files with missing lines Patch % Lines
access/grpc/grpc.go 78.57% 9 Missing and 6 partials ⚠️
access/grpc/convert/convert.go 0.00% 10 Missing ⚠️
access/grpc/client.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #764      +/-   ##
==========================================
+ Coverage   52.92%   55.62%   +2.70%     
==========================================
  Files          35       35              
  Lines        5580     5880     +300     
==========================================
+ Hits         2953     3271     +318     
+ Misses       2231     2139      -92     
- Partials      396      470      +74     
Flag Coverage Δ
unittests 55.62% <63.95%> (+2.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

access/grpc/grpc.go Outdated Show resolved Hide resolved
access/grpc/grpc.go Outdated Show resolved Hide resolved
@peterargue
Copy link
Contributor

@AndriiDiachuk please fix conflicts, then this is ready to merge

@peterargue peterargue merged commit 8b37d47 into onflow:master Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants