Merge pull request #397 from onflow/gregor/decode-fix

Return storage copy of data
onflow · Jul 29, 2024 · d1e1ffd · d1e1ffd
2 parents d61e717 + fef1458
commit d1e1ffd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/api/api.go b/api/api.go
@@ -883,7 +883,6 @@ func (b *BlockChainAPI) prepareBlockResponse(
 	fullTx bool,
 ) (*Block, error) {
 	h, err := block.Hash()
-	fmt.Println("### HASH", h)
 	if err != nil {
 		b.logger.Error().Err(err).Msg("failed to calculate hash for block by number")
 		return nil, errs.ErrInternal

diff --git a/storage/pebble/storage.go b/storage/pebble/storage.go
@@ -88,6 +88,10 @@ func (s *Storage) get(keyCode byte, key ...[]byte) ([]byte, error) {
 	prefixedKey := makePrefix(keyCode, key...)
 
 	data, closer, err := s.db.Get(prefixedKey)
+	// temp workaround to a weird bug where the data changes after returned
+	cp := make([]byte, len(data))
+	copy(cp, data)
+
 	if err != nil {
 		if errors.Is(err, pebble.ErrNotFound) {
 			return nil, errs.ErrNotFound
@@ -102,7 +106,7 @@ func (s *Storage) get(keyCode byte, key ...[]byte) ([]byte, error) {
 		}
 	}(closer)
 
-	return data, nil
+	return cp, nil
 }
 
 // batchGet loads the value from an indexed batch if data is found, else it loads the value from the storage.