Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing streaming methods #740

Merged
merged 6 commits into from
Sep 3, 2024
Merged

Conversation

bluesign
Copy link
Collaborator

@bluesign bluesign commented Aug 30, 2024

Closes #???

Description


For contributor use:

  • Targeted PR against master branch
  • Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the GitHub PR explorer
  • Added appropriate labels

@peterargue peterargue added the Improvement Technical work without new features, refactoring, improving tests label Aug 30, 2024
Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

server/access/streamBackend.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 65 lines in your changes missing coverage. Please review.

Project coverage is 35.31%. Comparing base (3f120d3) to head (a8624e8).
Report is 148 commits behind head on master.

Files with missing lines Patch % Lines
server/access/streamBackend.go 0.00% 53 Missing ⚠️
emulator/blockchain.go 0.00% 12 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3f120d3) and HEAD (a8624e8). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3f120d3) HEAD (a8624e8)
unittests 2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #740       +/-   ##
===========================================
- Coverage   51.24%   35.31%   -15.94%     
===========================================
  Files          34       47       +13     
  Lines        4533     7419     +2886     
===========================================
+ Hits         2323     2620      +297     
- Misses       2027     4610     +2583     
- Partials      183      189        +6     
Flag Coverage Δ
unittests 35.31% <0.00%> (-15.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@franklywatson franklywatson merged commit 5e1792d into master Sep 3, 2024
3 checks passed
@franklywatson franklywatson deleted the implementMissingStreaming branch September 3, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants