Add config option to allow upgrading legacy contracts #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am at a loss for how to do a good end to end test for this; I don't have a good way to generate old state to use as input for the test. |
dsainati1
requested review from
sideninja,
turbolent,
janezpodhostnik,
bluesign and
chasefleming
as code owners
SupunS
force-pushed
the
supun/update-deps
branch
from
5115cdb to
f1971b5
Compare
sideninja
approved these changes
Jan 25, 2024
|
Please also add this flag to the readme |
dsainati1
commented
Jan 25, 2024
| @@ -73,6 +73,8 @@ and if you plan to run the emulator with Docker you must use the environment var | |||
| | `--start-block-height` | `FLOW_STARTBLOCKHEIGHT` | `0` | Start block height to use when starting the network using 'testnet' or 'mainnet' as the chain-id | | |||
| | `--evm-enabled` | `FLOW_EVMENABLED` | `false` | Enable evm support | | |||
|
|
|||
| | `--legacy-upgrade` | `FLOW_LEGACYUPGRADE` | `false` | Enable upgrading of legacy contracts | | |||
There was a problem hiding this comment.
Do I need to do anything to get the docker flag here to work?
There was a problem hiding this comment.
Sorry, not quite sure what you mean here, how is this related to Docker?
…nto sainati/legacy-deploy
SupunS
approved these changes
Jan 26, 2024
…nto sainati/legacy-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of onflow/cadence#2947
This adds a server config option to the emulator that allows it to parse old Cadence contracts when set, for the purposes of allowing users to test contract updates to Cadence 1.0
For contributor use:
masterbranchFiles changedin the GitHub PR explorer