Updates ft and nft dependencies and basic transactions #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
joshuahannan
commented
Oct 1, 2024
joshuahannan
commented
- Updates the FT and NFT dependencies to include the latest transactions and contracts with improved error messages
- Updates the flow token transactions and basic account transactions to have better error messages
sisyphusSmiling
approved these changes
Oct 2, 2024
Comment on lines
+7
to
+20
| signatureAlgorithm >= 1 && signatureAlgorithm <= 3: | ||
| "Cannot add Key: Must provide a signature algorithm raw value that corresponds to " | ||
| .concat("one of the available signature algorithms for Flow keys.") | ||
| .concat("You provided ").concat(signatureAlgorithm.toString()) | ||
| .concat(" but the options are either 1 (ECDSA_P256), 2 (ECDSA_secp256k1), or 3 (BLS_BLS12_381).") | ||
| hashAlgorithm >= 1 && hashAlgorithm <= 6: | ||
| "Cannot add Key: Must provide a hash algorithm raw value that corresponds to " | ||
| .concat("one of of the available hash algorithms for Flow keys.") | ||
| .concat("You provided ").concat(hashAlgorithm.toString()) | ||
| .concat(" but the options are 1 (SHA2_256), 2 (SHA2_384), 3 (SHA3_256), ") | ||
| .concat("4 (SHA3_384), 5 (KMAC128_BLS_BLS12_381), or 6 (KECCAK_256).") | ||
| weight <= 1000.0: | ||
| "Cannot add Key: The key weight must be between 0 and 1000." | ||
| .concat(" You provided ").concat(weight.toString()).concat(" which is invalid.") |
There was a problem hiding this comment.
These updated error messages are really helpful, but I'm starting to wonder if there's a way we can standardize some of them as they're getting pretty long. Maybe something like FlowCoreErrors and in this instance invalidSigAlgo(_ provided: UInt8): String and invalidHashAlgo(_ provided: UInt8): String. Modifiers would be nice, but that's a whole new language feature.
There was a problem hiding this comment.
It is a little awkward right now, but once we have better string formatting in Cadence, then I think it won't be as bad. I think having a separate contract for it is a little unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.