WIP: Adds Proof of Possession verification during node registration #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarakby
force-pushed
the
proof-of-possesion
branch
from
6bb3b88 to
964d1ba
Compare
|
I've started to add the tests on top of your work, but eventually hit some issues with the contracts. They issues should be easier for you to solve. |
* update manifest.go and manifest files * add POP generation helper and add extra parameter to transactions * update contract comments * update to newest overflow and fixed tests (#306) * fix dependencies * add correct number of arguments to transactions * fix placeholds PoPs Co-authored-by: Bjarte S. Karlsen <[email protected]> Co-authored-by: Josh Hannan <[email protected]>
…roof-of-possesion
|
This PR is ready but will wait for the Ledger integration to be merged. This would simplify the contract updates during the future network sporks, while Ledger updates are being developed. |
joshuahannan
force-pushed
the
proof-of-possesion
branch
from
51cdbfb to
2fa1f75
Compare
…racts into proof-of-possesion
…roof-of-possesion
…racts into proof-of-possesion
|
Next step for this PR is to rebase on the stable Cadence branch |
|
Rebasing the PR on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/dapperlabs/flow-go/issues/6284
Adds a parameter to the
addNodeRecordmethod in the staking contract for the proof of possession.In the
NodeRecordinit function, this is verified with the staking key.Also updates the locked tokens contract, staking collection, and all of their transactions to include this parameter