Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test filename suffix #1785

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Add test filename suffix #1785

merged 2 commits into from
Oct 10, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Oct 8, 2024

Closes #1786

Description

Adds suffix to test files, was a bit of an oversight when I added this feature.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 29.71%. Comparing base (3a6202f) to head (f52ba0c).

Files with missing lines Patch % Lines
internal/super/generate.go 0.00% 3 Missing ⚠️
internal/super/generator/test_template.go 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1785      +/-   ##
==========================================
+ Coverage   29.69%   29.71%   +0.01%     
==========================================
  Files          94       94              
  Lines        5182     5182              
==========================================
+ Hits         1539     1540       +1     
+ Misses       3463     3462       -1     
  Partials      180      180              
Flag Coverage Δ
unittests 29.71% <69.23%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jribbink jribbink added the Improvement Technical work without new features, refactoring, improving tests label Oct 9, 2024
@jribbink jribbink merged commit b54a38f into master Oct 10, 2024
12 checks passed
@jribbink jribbink deleted the jribbink/test-name branch October 10, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add _test suffix when generating test files
3 participants