-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add contract migration check on all calls #1547
Merged
Merged
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
1d60627
remove version check in 1.0
ianthpun 7d3d289
add is_validated
ianthpun a2d3035
udpate
ianthpun 63d7a04
update
ianthpun 8c088cf
update
ianthpun 4b97f0f
add missing contracts
ianthpun bce8af0
update
ianthpun 6d8a8d3
resolve comments
ianthpun fe3475d
some cleanup
ianthpun 13d1582
fix slices
ianthpun 71b47a9
linter
ianthpun 1d5fd8e
update test
ianthpun aaa6383
update
ianthpun 63af7e6
update
ianthpun 8a16b1b
update
ianthpun 1ce938b
move to util
ianthpun 682c562
update
ianthpun 427d845
update
ianthpun 7a740d4
update
ianthpun 0e92418
udpate
ianthpun 339fb21
udpate
ianthpun 49fd909
Merge branch 'feature/stable-cadence' into ianthpun/validation-check
ianthpun 0ee2665
regenerate
ianthpun 87af46c
renegrate mocks
ianthpun 6e0170d
impoirt error
ianthpun e394a79
udpate
ianthpun 805e3a0
update
ianthpun bedd97b
formatter
ianthpun f607271
test fix
ianthpun 7796bac
fix test
ianthpun 93e569f
update
ianthpun 44d166d
update
ianthpun b518842
update
ianthpun 87cb8d0
update
ianthpun 37b40f1
update
ianthpun a49a609
fix skip
ianthpun 751ebbc
update
ianthpun 3a34a57
update
ianthpun a10057f
udpated with link check
ianthpun 026e718
update with better wording
ianthpun 21c87fb
update wording
ianthpun 25e164b
format
ianthpun f923a07
update state check
ianthpun 765164b
update
ianthpun a5f50ca
Update
ianthpun 98d0884
Merge branch 'feature/stable-cadence' into ianthpun/validation-check
ianthpun 67810c3
update copy
ianthpun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,6 +32,7 @@ import ( | |
|
||
"github.com/onflow/flow-cli/internal/command" | ||
"github.com/onflow/flow-cli/internal/scripts" | ||
"github.com/onflow/flow-cli/internal/util" | ||
) | ||
|
||
var getStagedCodeflags struct{} | ||
|
@@ -54,13 +55,13 @@ func getStagedCode( | |
flow flowkit.Services, | ||
state *flowkit.State, | ||
) (command.Result, error) { | ||
err := checkNetwork(flow.Network()) | ||
err := util.CheckNetwork(flow.Network()) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. moved |
||
if err != nil { | ||
return nil, err | ||
} | ||
|
||
contractName := args[0] | ||
addr, err := getAddressByContractName(state, contractName, flow.Network()) | ||
addr, err := util.GetAddressByContractName(state, contractName, flow.Network()) | ||
if err != nil { | ||
return nil, fmt.Errorf("error getting address by contract name: %w", err) | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleting this since this feature branch is literally 1.0