Add Cadence V0.42->V1.0 Update Checker to staging #1469
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/stable-cadence #1469 +/- ##
==========================================================
+ Coverage 41.40% 42.32% +0.92%
==========================================================
Files 59 59
Lines 3157 3324 +167
==========================================================
+ Hits 1307 1407 +100
- Misses 1664 1716 +52
- Partials 186 201 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jribbink
requested review from
Kay-Zee,
janezpodhostnik,
sideninja,
chasefleming,
nvdtf,
bluesign,
bjartek and
ianthpun
as code owners
jribbink
changed the title
jribbink
added
the
Improvement
|
|
||
| var _ error = &missingDependenciesError{} | ||
|
|
||
| var chainIdMap = map[string]flow.ChainID{ |
There was a problem hiding this comment.
I've had to do this several times as well. I wonder if there is a way we could break this out to be reusable.
There was a problem hiding this comment.
Yeah, just a flowkit helper for converting flowkit chain id to flow-go chainid would be good enough here
| } | ||
| } | ||
|
|
||
| func (v *stagingValidator) ValidateContractUpdate( |
There was a problem hiding this comment.
This is quite long. Thoughts on breaking this up for readability?
Closes #1453
Description
Validates your proposed contract update against other staged contracts on chain.
For contributor use:
masterbranchFiles changedin the Github PR explorer